KEP-3314: adding beta PRR documentation by carlbraganza · Pull Request #5877 · kubernetes/enhancements

carlbraganza · 2026-02-02T21:41:39Z

One-line PR description: Update KEP-3314 PRR for Beta.

Issue link: CSI Differential Snapshot for Block Volumes #3314

Other comments:

k8s-ci-robot · 2026-02-02T21:41:49Z

Hi @carlbraganza. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

xing-yang · 2026-02-02T22:14:01Z

/ok-to-test

xing-yang · 2026-02-02T22:16:03Z

You need to update https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/3314-csi-changed-block-tracking/kep.yaml and https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-storage/3314.yaml

keps/sig-storage/3314-csi-changed-block-tracking/README.md

xing-yang · 2026-02-03T17:23:12Z

General comment: Please provide more details when you say "CSI driver specific."

For e2e tests, please include links to the test files.

stlaz

PRR shadow review

keps/sig-storage/3314-csi-changed-block-tracking/README.md

stlaz · 2026-02-04T14:08:36Z

keps/sig-storage/3314-csi-changed-block-tracking/README.md

+installed by the CSI driver, or by
+reinstalling the CSI driver without this feature enabled.
+
+It can also be effectively disabled by modifying the CSI driver specific


You would still likely have at least one cluster-admin in the cluster that could still use it. I wouldn't say this is a valid way to disable the feature.

Okay, I'll remove this.

keps/sig-storage/3314-csi-changed-block-tracking/README.md

carlbraganza

@stlaz I hope I've addressed all your feedback.

keps/sig-storage/3314-csi-changed-block-tracking/README.md

carlbraganza · 2026-02-04T19:11:43Z

keps/sig-storage/3314-csi-changed-block-tracking/README.md

+installed by the CSI driver, or by
+reinstalling the CSI driver without this feature enabled.
+
+It can also be effectively disabled by modifying the CSI driver specific


Okay, I'll remove this.

keps/sig-storage/3314-csi-changed-block-tracking/README.md

stlaz · 2026-02-09T09:19:01Z

keps/sig-storage/3314-csi-changed-block-tracking/README.md

  [TokenReview](https://kubernetes.io/docs/reference/kubernetes-api/authentication-resources/token-review-v1/) and
  [SubjectAccessReview](https://kubernetes.io/docs/reference/kubernetes-api/authorization-resources/subject-access-review-v1/)
  APIs are controlled by Kubernetes security policy.
+  A side effect of the use of these APIs is that it partially mitigates


@kubernetes/sig-auth-proposals This KEP suggests that an unauthenticated client can cause N authenticated clients to fan out requests to the KAS until KAS starts rate-limiting each of these authenticated clients. N is the number of CSI driver instances installed in the cluster.

Is this ok?

keps/sig-storage/3314-csi-changed-block-tracking/README.md

stlaz · 2026-02-09T09:25:24Z

keps/sig-storage/3314-csi-changed-block-tracking/README.md

-No integration tests are required. This feature is better tested with e2e tests.
+[Integration tests](https://github.com/kubernetes-csi/external-snapshot-metadata/blob/main/.github/workflows/integration-test.yaml)


Permanent link, please.

Why is this considered an integration test?

Can we point to actual testing code, not the workflow that runs them?

I think that is because its run as part of the CI steps. Its scope is beyond that of a unit test.

I've changed the link to a permanent link.

I think that is because its run as part of the CI steps. Its scope is beyond that of a unit test.

Yes, but the way these tests work actually makes them e2e tests, not integration tests. You're testing an actual user scenario from start to finish, rather than observing how certain units interact with each other in a simulated/isolated environment.

When you actually need a running kube cluster for a test, you're not very likely to be doing integration testing.

keps/sig-storage/3314-csi-changed-block-tracking/README.md

stlaz · 2026-02-09T09:46:35Z

keps/sig-storage/3314-csi-changed-block-tracking/README.md

+block mode backups should become more efficient in both storage
+space and time utilization.
+The `GetMetadataAllocated` and `GetMetadataDelta` snapshot metadata operations
+should be successful most of time.


Define "most of the time" with a specific number.

I have no basis on which to propose a number. Given that nothing is 100% successful, I reworded this in relative terms:

The GetMetadataAllocated and GetMetadataDelta snapshot metadata operations
should be as successful as an existing CreateSnapshot CSI operation on the
same volume, assuming that sufficient cluster resources are available for the
duration of the operation.

soltysh

A few more questions from PRR

keps/sig-storage/3314-csi-changed-block-tracking/kep.yaml

keps/sig-storage/3314-csi-changed-block-tracking/README.md

soltysh · 2026-02-10T20:18:22Z

keps/sig-storage/3314-csi-changed-block-tracking/README.md

-No integration tests are required. This feature is better tested with e2e tests.
+[Integration tests](https://github.com/kubernetes-csi/external-snapshot-metadata/blob/main/.github/workflows/integration-test.yaml)


Can we point to actual testing code, not the workflow that runs them?

soltysh · 2026-02-10T20:19:23Z

keps/sig-storage/3314-csi-changed-block-tracking/README.md

 We expect no non-infra related flakes in the last month as a GA graduation criteria.
 -->

+Link: [SnapshotMetadata E2E test PR](https://github.com/kubernetes/kubernetes/pull/130918)


These tests are part of alpha requirements, and they are NOT merged yet. So how are you planning to deliver beta?

Are there others, can you link them here?

Can we point to actual testing code, not the workflow that runs them?

I changed the text to read:

Integration tests are built into the build process. The test is based on the CSI Hostpath driver and uses the snapshot-metadata-lister and snapshot-metadata-verifier commands built by in the external-snapshot-metadata repository, yq, kubectl and other standard Linux utilities. See the workflow script for test details.

These tests are part of alpha requirements, and they are NOT merged yet. So how are you planning to deliver beta?

Others are working on getting this merged ASAP.

These tests are part of alpha requirements, and they are NOT merged yet. So how are you planning to deliver beta?

I see the linked PR is tagged for merge, that's a bit better.

@carlbraganza can you replace the PR with this link for the merged test? https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/testsuites/snapshot-metadata.go

soltysh · 2026-02-10T20:21:12Z

keps/sig-storage/3314-csi-changed-block-tracking/kep.yaml

 feature-gates:
  - name: 
    components:
 disable-supported: true


Can you put here information, that this is separate component. I keep forgetting that and need to look in other places for this.

soltysh

/approve
the PRR section

soltysh · 2026-02-11T12:24:48Z

keps/sig-storage/3314-csi-changed-block-tracking/README.md

 We expect no non-infra related flakes in the last month as a GA graduation criteria.
 -->

+Link: [SnapshotMetadata E2E test PR](https://github.com/kubernetes/kubernetes/pull/130918)


These tests are part of alpha requirements, and they are NOT merged yet. So how are you planning to deliver beta?

I see the linked PR is tagged for merge, that's a bit better.

xing-yang · 2026-02-11T14:04:51Z

Test PR kubernetes/kubernetes#130918 is merged.
Please submit a followup PR to replace it with a link to the merged test file: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/testsuites/snapshot-metadata.go

/lgtm
/approve

k8s-ci-robot · 2026-02-11T14:05:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlbraganza, soltysh, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~keps/prod-readiness/OWNERS~~ [soltysh]
~~keps/sig-storage/OWNERS~~ [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Feb 2, 2026

k8s-ci-robot requested a review from saad-ali February 2, 2026 21:41

k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Feb 2, 2026

k8s-ci-robot requested a review from xing-yang February 2, 2026 21:41

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 2, 2026

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 2, 2026

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2026

carlbraganza force-pushed the kep3314-beta branch from ab59cb0 to 55efa98 Compare February 2, 2026 22:32

xing-yang mentioned this pull request Feb 2, 2026

CSI Differential Snapshot for Block Volumes #3314

Open

8 tasks

carlbraganza force-pushed the kep3314-beta branch from 55efa98 to 0495898 Compare February 2, 2026 22:40

xing-yang reviewed Feb 2, 2026

View reviewed changes

carlbraganza force-pushed the kep3314-beta branch 4 times, most recently from 6f475d4 to 943a783 Compare February 3, 2026 16:35

carlbraganza requested a review from xing-yang February 3, 2026 16:39

xing-yang reviewed Feb 3, 2026

View reviewed changes

carlbraganza force-pushed the kep3314-beta branch from 943a783 to 1d3cb5e Compare February 3, 2026 19:49

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 3, 2026

carlbraganza requested a review from xing-yang February 3, 2026 19:51

stlaz suggested changes Feb 4, 2026

View reviewed changes

carlbraganza mentioned this pull request Feb 4, 2026

Suggested unit test improvement from stlaz kubernetes-csi/external-snapshot-metadata#206

Closed

carlbraganza commented Feb 4, 2026

View reviewed changes

carlbraganza force-pushed the kep3314-beta branch from 1d3cb5e to 53cbccf Compare February 4, 2026 21:39

carlbraganza requested a review from stlaz February 4, 2026 21:40

carlbraganza force-pushed the kep3314-beta branch from 53cbccf to 8d7844d Compare February 4, 2026 22:04

stlaz suggested changes Feb 9, 2026

View reviewed changes

k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. kind/design Categorizes issue or PR as related to design. labels Feb 9, 2026

enj moved this to Needs Triage in SIG Auth Feb 9, 2026

enj added this to SIG Auth Feb 9, 2026

soltysh reviewed Feb 10, 2026

View reviewed changes

carlbraganza force-pushed the kep3314-beta branch from 8d7844d to 4a04124 Compare February 10, 2026 23:40

carlbraganza requested review from soltysh and stlaz February 10, 2026 23:42

carlbraganza force-pushed the kep3314-beta branch from 4a04124 to 428c1a5 Compare February 11, 2026 00:04

Beta PRR update.

7ba75b7

carlbraganza force-pushed the kep3314-beta branch from 428c1a5 to 7ba75b7 Compare February 11, 2026 00:50

soltysh approved these changes Feb 11, 2026

View reviewed changes

github-project-automation bot moved this from Needs Triage to In Review in SIG Auth Feb 11, 2026

k8s-ci-robot assigned xing-yang Feb 11, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2026

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2026

k8s-ci-robot merged commit 7d9b02e into kubernetes:master Feb 11, 2026
4 checks passed

k8s-ci-robot added this to the v1.36 milestone Feb 11, 2026

github-project-automation bot moved this from In Review to Closed / Done in SIG Auth Feb 11, 2026

		No integration tests are required. This feature is better tested with e2e tests.
		[Integration tests](https://github.com/kubernetes-csi/external-snapshot-metadata/blob/main/.github/workflows/integration-test.yaml)

Conversation

carlbraganza commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Feb 2, 2026

Uh oh!

xing-yang commented Feb 2, 2026

Uh oh!

xing-yang commented Feb 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xing-yang commented Feb 3, 2026

Uh oh!

stlaz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carlbraganza left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carlbraganza Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

carlbraganza commented Feb 2, 2026 •

edited

Loading

carlbraganza Feb 10, 2026 •

edited

Loading

carlbraganza Feb 10, 2026 •

edited

Loading